Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom boost::locale::numpunct #170

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

Flamefire
Copy link
Collaborator

Rebase of #65 onto develop with current changes incorporated. Hence closes #65

Contains the original commit(s) from @salvoilmiosi of #65 squashed and rebased onto develop to fix the conflicts.
On top some refactoring and documentation additions to suit current state of the library.

Will also contain tests.

Design:

  • provide boost::locale::numpunct for all backends
  • add decimal_point_str & thousands_sep_str to provide possibly encoded variants of the decimal and thousand separators
  • decimal_point & thousands_sep return best-effort single-chars, by default falling back to the "C" locale
  • Tests should ensure that a Boost.Locale agnostic library (i.e. reading facet.thousands_sep() & facet.decimal_point() and doing "regular" streaming using std::locale) get the expected results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants